[Webkit-unassigned] [Bug 79649] Web Inspector: WebKit2: need API to when the Inspector is in the front

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79649





--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2012-02-27 08:58:12 PST ---
(In reply to comment #3)
> (From update of attachment 128990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128990&action=review
> 
> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:126
> > +        [menuItem setTitle:WEB_UI_STRING("Hide Web Inspector", "title for Hide Web Inspector menu item")];
> 
> Don’t you also need to handle the “Show Web Inspector” case here?

No, sicne if the Web Inspector's window delegate is handleing the validation we know it is front. I'll add a comment.

> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:257
> > +    return m_isVisible && [m_inspectorView.get().window isMainWindow];
> 
> It would be good to reference a bug number in this FIXME.

Will do.

I'll fix those and the Windows build and upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.