[Webkit-unassigned] [Bug 79649] Web Inspector: WebKit2: need API to when the Inspector is in the front

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 06:06:58 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79649


John Sullivan <sullivan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128990|review?                     |review-
               Flag|                            |




--- Comment #3 from John Sullivan <sullivan at apple.com>  2012-02-27 06:06:57 PST ---
(From update of attachment 128990)
View in context: https://bugs.webkit.org/attachment.cgi?id=128990&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:126
> +        [menuItem setTitle:WEB_UI_STRING("Hide Web Inspector", "title for Hide Web Inspector menu item")];

Don’t you also need to handle the “Show Web Inspector” case here?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:257
> +    return m_isVisible && [m_inspectorView.get().window isMainWindow];

It would be good to reference a bug number in this FIXME.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list