[Webkit-unassigned] [Bug 73156] [Microdata] Implement HTMLPropertiesCollection collection.namedItem()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73156





--- Comment #16 from Arko Saha <nghq36 at motorola.com>  2012-02-27 01:43:21 PST ---
(In reply to comment #15)
> (From update of attachment 126761 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126761&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please describe what the patch is doing.

Ok, I will update the Changelog.

> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2235
> > +    if ($interfaceName eq "HTMLPropertiesCollection") {
> 
> Maybe you can remove the hard-coding by using [CustomNamedGetter] (or [JSCustomNamedGetter]). https://trac.webkit.org/wiki/WebKitIDL#CustomNamedGetter

To use [CustomNamedGetter] or [NamedGetter] we need to define JSPropertiesCollection::canGetItemsForName() and JSPropertiesCollection::nameGetter() in JSPropertiesCollectionCustom.cpp

Please check my previous patch https://bugs.webkit.org/attachment.cgi?id=124521&action=prettypatch. Here I have used [NamedGetter] and defined above functions in JSPropertiesCollection.cpp. Is this approach is correct?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.