[Webkit-unassigned] [Bug 75464] [EFL][WK2] Add ProcessLauncherEfl.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 23:24:39 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=75464





--- Comment #12 from YoungTaeck Song <youngtaeck.song at samsung.com>  2012-02-26 23:24:39 PST ---
(In reply to comment #10)
> (From update of attachment 128954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128954&action=review
> 
> > Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70
> > +        ssize_t result = readlink("/proc/self/exe", readLinkBuffer, PATH_MAX);
> > +
> > +        if (result == -1)
> > +            executablePath = String("/usr/bin");
> > +        else {
> > +            char* executablePathPtr = dirname(readLinkBuffer);
> > +            executablePath = String(executablePathPtr);
> > +        }
> 
> readlink() doesn't append a '\0' character. dirname() will read uninitialized memory in the 'else' branch here.

Thank you for your kind review.
I fixed it at the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list