[Webkit-unassigned] [Bug 79274] Fix <msubsup> formatting, especially for a tall base, subscript, or superscript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79274


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128924|review?                     |
               Flag|                            |




--- Comment #29 from Julien Chaffraix <jchaffraix at webkit.org>  2012-02-26 21:44:26 PST ---
(From update of attachment 128924)
View in context: https://bugs.webkit.org/attachment.cgi?id=128924&action=review

I think the test failure is a flake. The patch looks good to me, just a couple of tweaks and it is ready to get in.

> Source/WebCore/ChangeLog:3
> +        Fix <msubsup> formatting

You missed the bug title change in your ChangeLog's update.

> Source/WebCore/ChangeLog:12
> +        Test: 6 existing test files in mathml/presentation now produce improved results,

Nit: for posterity, you could copy the improvements you mentioned in the bug here.

> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:152
> +    // FIXME: Julien Chaffraix suggests that we add some way to check or ASSERT() that subscript and
> +    // superscript are what we think they are, not some :before or :after content or other (future?)
> +    // possibility.

Don't need to mention me (though I like the thought :)). We usually don't mention people in FIXMEs: people change, FIXME usually don't. Here it could be:

// FIXME: We should ASSERT that |subscript| and |superscript| are really the renderers we want (for example generated content could change our hierarchy and confuse us).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.