[Webkit-unassigned] [Bug 79191] [JSC] The end atom of the marked block should be considered to decide if the cell is live

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 20:55:47 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79191





--- Comment #3 from hojong.han at samsung.com  2012-02-26 20:55:47 PST ---
(In reply to comment #2)
> (From update of attachment 128150 [details])
> This feels strange.  Either it is possible, due to the conservative nature of the stack scans, that we will see a pointer that passes the not-cell-middle test but is nonetheless beyond m_endAtom, or it isn't.  If it is, this patch will make us crash in debug mode and do the right thing in release mode.  If it is not possible, then this patch just adds noise.
> 
> So which is it?  Can you justify why you've added code that results in assertion failures for the case that you're claiming to handle?

The situation you described is the reason why I've added code. 
There were some crashes, I've analyzed, caused by a pointer beyond m_endAtom.
That unusual pointer was added to registerFileRoots while gathering conservative roots, but I've not figured out how the pointers beyond m_endAtom were used and could be existed in the register file.
I expect this patch will make crash with more information in debug mode and do the right this in release.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list