[Webkit-unassigned] [Bug 79601] [EFL] [DRT] Implement scheduleAsynchronousKeyDown.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79601


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128912|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-02-26 18:09:50 PST ---
(From update of attachment 128912)
View in context: https://bugs.webkit.org/attachment.cgi?id=128912&action=review

By the way, can't this patch remove skipped test cases? If so, you need to update Skipped file.

> Tools/DumpRenderTree/efl/EventSender.cpp:445
> +        return;

It looks it is better to add an empty line to here.

> Tools/DumpRenderTree/efl/EventSender.cpp:460
> +    free(keyEventInfo);

When you change malloc with new. You have to change free() with delete as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.