[Webkit-unassigned] [Bug 79608] Getting the instruction stream for a code block should not require two loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79608





--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2012-02-26 14:03:14 PST ---
(In reply to comment #3)
> (From update of attachment 128927 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128927&action=review
> 
> > Source/JavaScriptCore/wtf/CompactVector.h:40
> > +// ** This could be modified to support non-POD values quite easily. It just
> > +//    hasn't been, so far, because there has been no need.
> 
> Seems like it would be worth adding COMPILE_ASSERTs to prevent usage of non-POD

Yeah, I'll do that.

> 
> > Source/JavaScriptCore/wtf/CompactVector.h:71
> > +        for (unsigned i = other.size(); i--;)
> > +            m_data[i] = other[i];
> 
> Why not just use memcpy here? Also I'm not 100% comfortable with the implicit vector copy -- at the very least can we make these contractors explicit?

You're right, this should be an explicit contractor.

(Contractor is the new constructor.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.