[Webkit-unassigned] [Bug 79274] Fix <msubsup> formatting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79274





--- Comment #26 from Julien Chaffraix <jchaffraix at webkit.org>  2012-02-26 12:05:18 PST ---
(From update of attachment 128903)
View in context: https://bugs.webkit.org/attachment.cgi?id=128903&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        Fix <msubsup> formatting
>> 
>> BTW usually we prefer bugzilla bug titles to be more precise. Here it's difficult to understand what cases you want to fix (all of them? certain ones? in this case which ones?)
> 
> Good point. I can't change the title now, right?

Sure you can. If you don't have EditBug permission on bugzilla, you can only change your own bug's name though.

It's always welcome to improve the title of a bug.

>>> Source/WebCore/ChangeLog:12
>>> +        Test: 6 existing test files in mathml/presentation now produce improved results,
>> 
>> Saying how improved they are would help us, people who don't know what MathML should look like. From the traces, it looks like they are more densely laid out but I don't know if it's good or not.
> 
> I've added the main test case as an attachment to the bug. The real issue is vertical positioning of the subscript and superscript, allowing for arbitrary sizes of the various parts (base, subscript, superscript), together with some code clean-up.

Allowing arbitrary subscript and superscript size sounds like something the bug title should reflect IMHO. The clean-up part can be mentioned in the ChangeLog.

>>> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:141
>>> +    RenderObject* subscriptWrapper = m_scripts->lastChild();
>> 
>> First, the name should be proper camelCase ie superScriptWrapper! (unless those are supposed to be some keywords and I missed it in the spec)
>> 
>> Please add 2 ASSERTs here:
>> ASSERT(superScriptWrapper->isRenderMathMLBlock());
>> ASSERT(subScriptWrapper->isRenderMathMLBlock());
> 
> subscript and superscript are definitely english words and standard mathematical ones (http://en.wikipedia.org/wiki/Subscript_and_superscript, MathML spec, etc.).
> 
> I'll add the ASSERT()s.

OK, I am not a native speaker and I am not super familiar with mathml so feel free to push back if some suggestions don't make sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.