[Webkit-unassigned] [Bug 79518] Web Inspector: Close TabbedPanes on middle click of tab handle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79518


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128895|review?                     |review+
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2012-02-26 09:31:02 PST ---
(From update of attachment 128895)
View in context: https://bugs.webkit.org/attachment.cgi?id=128895&action=review

Thanks for the fix, I'll fix the ChangeLog and land it.

> Source/WebCore/ChangeLog:6
> +        Reviewed by Alexander Pavlov.

To avoid further confusion, let me clarify. ChangeLog must contain "Reviewed by NOBODY (OOPS!)." string. No other OOPS should be there. Reviewer is being filled in upon landing automatically.

> Source/WebCore/inspector/front-end/TabbedPane.js:618
> +        if (this._closeable && (event.button === 1 || event.target.hasStyleClass("tabbed-pane-header-tab-close-button")))

nit: I would make closeButtonSpan tab's field and compare it here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.