[Webkit-unassigned] [Bug 79478] LayerTreeHostProxy uses Functional instead of MessageQueue for accumulating tasks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79478


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128853|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-02-25 07:55:01 PST ---
(From update of attachment 128853)
View in context: https://bugs.webkit.org/attachment.cgi?id=128853&action=review

Awesome!
Some touch ups and we're good.

> Source/WebKit2/ChangeLog:8
> +        It is succinct to collect tasks using Functional because of reducing codes about
> +        boilerplate message definition.

Please reword changelog (just an English touch-up):
Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy renderer. This makes a lot of the broilerplate code for message-passing unnecessary, and results in a much more succinct implementation.

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:92
> +    Vector<Function<void()> > m_functionQueue;

m_functionQueue -> m_renderQueue

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.