[Webkit-unassigned] [Bug 79518] Web Inspector: Close TabbedPanes on middle click of tab handle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79518





--- Comment #4 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-02-24 23:21:59 PST ---
(From update of attachment 128857)
View in context: https://bugs.webkit.org/attachment.cgi?id=128857&action=review

You need a ChangeLog entry for WebKit patches as well. It can be put together by the Tools/Scripts/prepare-ChangeLog script. I believe having one, together with the comparison fix (see below), will qualify as a good patch.

> Source/WebCore/inspector/front-end/TabbedPane.js:619
> +            if (event.button == 1 || event.target.hasStyleClass("tabbed-pane-header-tab-close-button"))

Sorry for overlooking this, we use the === comparison whenever possible.

Also, don't forget to set the r? flag on the patches you upload for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.