[Webkit-unassigned] [Bug 79518] Web Inspector: Close TabbedPanes on middle click of tab handle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79518


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128780|                            |review?
               Flag|                            |




--- Comment #2 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-02-24 22:43:27 PST ---
(From update of attachment 128780)
View in context: https://bugs.webkit.org/attachment.cgi?id=128780&action=review

> Source/WebCore/inspector/front-end/TabbedPane.js:619
> +            if (event.button == 1 || event.target.classList.contains('tabbed-pane-header-tab-close-button'))

Quotes are used instead of apostrophes for string literals across Web Inspector.
Also, to determine if a CSS class is present on an element, you should use event.target.hasStyleClass("tabbed-pane-header-tab-close-button"); for better readability (Element.prototype.hasStyleClass is defined in utilities.js).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.