[Webkit-unassigned] [Bug 78028] Decouple scrollbar painting from Scrollbar object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78028





--- Comment #39 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-02-24 15:55:33 PST ---
Attachment 128821 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:39:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/RenderScrollbarTheme.h:59:  The parameter name "scrollbar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/ScrollbarThemeEfl.h:42:  The parameter name "scrollbar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/efl/ScrollbarThemeEfl.h:43:  The parameter name "scrollbar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/mac/ScrollbarThemeMac.h:45:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:35:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:61:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:62:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:63:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:64:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:65:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarThemeComposite.h:66:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/Scrollbar.h:96:  The parameter name "e" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/ScrollbarTheme.h:84:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarTheme.h:109:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/ScrollbarTheme.h:110:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/Scrollbar.cpp:117:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 17 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.