[Webkit-unassigned] [Bug 76677] AXPress event coordinates are always sent as (0, 0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76677


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128771|review?                     |review-
               Flag|                            |




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-02-24 11:43:53 PST ---
(From update of attachment 128771)
View in context: https://bugs.webkit.org/attachment.cgi?id=128771&action=review

> Source/WebCore/dom/MouseEvent.cpp:184
> +        int clientX = rect.location().x() + rect.size().width() / 2;
> +        int clientY = rect.location().y() + rect.size().height() / 2;

absoluteBoundingBoxRect is document-relative. clientX and clientY should be viewport-relative, given their names.

This will break in subframes, CSS-transformed subframes, and scrolled documents. All these cases should be tested.

> Source/WebCore/dom/MouseEvent.cpp:186
> +        m_screenLocation = IntPoint(clientX + domWindow->screenX(), clientY + domWindow->screenY());

I don't think that's a good way to convert to screen coordinates.

It would be best to use the methods on Widget.h to convert to the containing window. Not sure how best to go from there to the screen.

> LayoutTests/ChangeLog:6
> +        Make sure AXPress events target an elements center point.

element's

> LayoutTests/platform/mac/accessibility/press-event-has-target-coordinates.html:8
> +<button id="button" style="height:30px; width:60px;">Submit</button>

It would be nice to test with a CSS-transformed element too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.