[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 24 10:36:37 PST 2012


--- Comment #49 from Chris Rogers <crogers at google.com>  2012-02-24 10:36:37 PST ---
(In reply to comment #48)
> (In reply to comment #45)
> > (In reply to comment #42)
> > > (In reply to comment #41)
> > > > (From update of attachment 127768 [details] [details] [details] [details])
> > > > View in context: https://bugs.webkit.org/attachment.cgi?id=127768&action=review
> > > > 
> > > > I think the commit queue bot needs to have the ChangeLog include the "Reviewed by..." line.  Please re-upload patch with this fix.
> > > > 
> > > > Xingnan, I'm assuming you've run the layout tests locally on your linux box with IPP enabled and that they passed.  Also, please verify that this page works with the IPP code running:
> > > > http://chromium.googlecode.com/svn/trunk/samples/audio/mag-phase.html
> > > > 
> > > Chris, I will re-run the latest layout tests and verify the demo.
> > Layout tests are OK.
> > The demo looks generally good, but I found there is deviation that the magnitude mismatched in lowpass.
> This doesn't make any sense to me.  The frequency response should not depend on whether we are using IPP or not.  The only thing I can think of is that the filter coefficients are somehow slightly different between the two graphs.  The displayed values for cutoff, Q, and gain are not printed to full precision.

Wow, that's really interesting.  Can you try to debug a little bit more and maybe add some "printf" statements to determine what the calculated filter coefficients are in the two cases?

How do the filters sound when filtering the noise?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list