[Webkit-unassigned] [Bug 79167] Expose a setting to exempt media playback from user gesture requirement after a user gesture is initiated on loading/playing a media

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79167





--- Comment #21 from Min Qin <qinmin at chromium.org>  2012-02-24 09:18:46 PST ---
(In reply to comment #18)
> (From update of attachment 128583 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128583&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:4057
> > +void HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture()
> > +{
> > +    m_restrictions = NoRestrictions;
> > +}
> 
> I'm trying to understand whether we're removing too many restrictions here.  I need to re-read the bug thread.
> 
> > Source/WebCore/html/HTMLMediaElement.h:479
> > +    // Remove behavior restrictions after user requested load/play
> 
> I would skip this comment.  It's pretty redundant with the name of the method.

Done, comments removed.

> 
> > LayoutTests/media/video-play-require-user-gesture.html:10
> > +            if (window.internals) 
> > +	        window.internals.setMediaPlaybackRequiresUserGesture(document, true);
> 
> Looks like there's some problem with you indent here.

Removed the offending tab and fixed the indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.