[Webkit-unassigned] [Bug 79031] [EFL] Make a pair between evas_object_image_data_set/get.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79031





--- Comment #4 from JungJik Lee <jungjik.lee at samsung.com>  2012-02-24 08:23:23 PST ---
(In reply to comment #2)
> > Source/WebKit/efl/ChangeLog:8
> > +        - We get the pixel data when we create the cairo surface.
> 
> We ?
> 
I've changed the word.
> > Source/WebKit/efl/ChangeLog:10
> > +        We should make a pair between evas_object_image_data_set/get to return evas resource.
> 
> I suggest you to specify the reason of evas_object_image_data_set too.
> So, it can be a complete sentence.
> 
I append more description.
> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:52
> > +    uint8_t* pixels = static_cast<uint8_t*>(evas_object_image_data_get(tile->image, EINA_TRUE));
> 
> EINA_TRUE should be replaced.
Done.
> 
> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:76
> > +    cairo_identity_matrix(cairo.get());
> 
> I don't think that cairo_identity_matrix() would be required. would you double check ?
It's removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.