[Webkit-unassigned] [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49543





--- Comment #36 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-24 02:41:47 PST ---
(From update of attachment 124721)
View in context: https://bugs.webkit.org/attachment.cgi?id=124721&action=review

I know this already landed, but I've found some issues with the patch.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:353
> +    /*

Double * missing here

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:354
> +     * WebKitWebFrame::resource-response-received

Trailing : missing

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:355
> +     * @webFrame: the #WebKitWebFrame the response was received for

web_frame

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:356
> +     * @webResource: the #WebKitWebResource being loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:359
> +     * Emitted when the first byte of data arrives

Are you sure, this is emitted when the response is received from the server, when the first byte of data arrives, received-content-length is emitted.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:373
> +    /*

Double * missing here too

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:374
> +     * WebKitWebFrame::resource-load-finished

And trailing :

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:375
> +     * @webFrame: the #WebKitWebFrame the response was received for

web_frame

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:376
> +     * @webResource: the #WebKitWebResource being loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:391
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:393
> +     * @webFrame: the #WebKitWebFrame the response was received for

web_frame

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:394
> +     * @webResource: the #WebKitWebResource that was loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:395
> +     * @lengthReceived: the resource data length in bytes

length_received. It's not the length of the resource, it the bytes received in this moment

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:397
> +     * Emitted when all the data for the resource was loaded.

Received every time data is received. This is called every time data has been received and length_received is the amount of bytes received. This is useful to provide progress information about the resource load operation.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:411
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:412
> +     * WebKitWebFrame::resource-load-failed

Trailing :

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:413
> +     * @webFrame: the #WebKitWebFrame the response was received for

web_frame

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:414
> +     * @webResource: the #WebKitWebResource that was loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:415
> +     * @webError: the #GError that was triggered

error

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:125
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:126
> +     * WebKitWebResource::response-received

Trailing :

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:127
> +     * @webResource: the #WebKitWebResource being loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:130
> +     * Emitted when the first byte of data arrives

Same comment here about the first byte of data

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:143
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:144
> +     * WebKitWebResource::load-failed

Trailing :

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:145
> +     * @webResource: the #WebKitWebResource that was loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:146
> +     * @webError: the #GError that was triggered

error

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:148
> +     * Invoked when a resource failed to load

This is emitted on the resource object, it should probably say 'Invoked when the resource failed to load' or even 'Invoked when @resource failed to load'

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:161
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:162
> +     * WebKitWebResource::load-finished

Trailing :

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:163
> +     * @webResource: the #WebKitWebResource being loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:177
> +    /*

Double *

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:178
> +     * WebKitWebResource::content-length-received

Trailing :

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:179
> +     * @webResource: the #WebKitWebResource that was loaded

web_resource

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:180
> +     * @lengthReceived: the resource data length in bytes

length_received

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:182
> +     * Emitted when all the data for the resource was loaded

Same comment here about what this signal is for.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:214
> +    RESOURCE_RESPONSE_RECEIVED,
> +    RESOURCE_LOAD_FINISHED,
> +    RESOURCE_CONTENT_LENGTH_RECEIVED,
> +    RESOURCE_LOAD_FAILED,

Same comments for this file too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.