[Webkit-unassigned] [Bug 78980] SVG error parsing empty path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 24 00:47:31 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78980


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128506|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-24 00:47:31 PST ---
(From update of attachment 128506)
Hi Joe, thanks for the patch! Phillip is right, that this is rather a work-around than a fix.
If we want to treat an empty path as valid, SVGPathParserFactor::buildXXXFromString() needs to be fixed.
There are various ways to convert a SVGPathByteStream to a String, and/or a SVGPathSegList - I guess you'd need to inspect all these code paths, to make sure we deal with empty paths correctly.

Also your change lacks test coverage, where this actually affects a test, despite the error printing which is now gone.
Can you investigate more?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list