[Webkit-unassigned] [Bug 78684] Layout issue with fieldset legend element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 23:40:56 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78684





--- Comment #25 from SravanKumar S <ssandela at innominds.com>  2012-02-23 23:40:56 PST ---
:), some response in between is tempting enough to keep persisting with trials.
Ok, any how before i upload the patch again, i need one quick clarification, one of the patch has following lines in it, will it go through style bot?

Index: LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png
===================================================================
- LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png (revision 0)
+++ LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png (working copy)

Property changes on: LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+image/png

I am sure it wont go through, so i 
1. back up -expected.png
2. svn delete "xyz-expected.png"
3. touch "xyz-expected.png"
4. svn add "xyz-expected.png"
5. re-baseline to regenerate "xyz-expected.png"
6. Now re-generate the patch again,

Then i dont see above lines in the patch, but patch size is increased and png file has some non-readable characters in patch file. And i upload this file as patch.

So based on my above explanation can you let me know how to counter these issues and create a safe patch and upload it. I am using cygwin(CYGWIN_NT-6.1-WOW64) svn1.7 on Win7

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list