[Webkit-unassigned] [Bug 45416] Allow Chromium port to link with system-provided SQLite

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45416


Xianzhu Wang <wangxianzhu at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
         AssignedTo|wangxianzhu at chromium.org    |webkit-unassigned at lists.web
                   |                            |kit.org




--- Comment #22 from Xianzhu Wang <wangxianzhu at chromium.org>  2012-02-23 18:25:20 PST ---
(In reply to comment #21)

> Q1: Other than reducing size, why is this needed for chromium-android? What is different about android's library that forces the need to dynamically link with it? Or is the need purely based on reducing size?
> 
> Q2: Can we modify android's sqlite system library?
> That might change the shape of the answer. Specifically can android's system library export these symbols... 
> 
> // Defined in Chromium's codebase in third_party/sqlite/src/os_unix.c
> extern "C" {
> void chromium_sqlite3_initialize_unix_sqlite3_file(sqlite3_file* file);
> int chromium_sqlite3_fill_in_unix_sqlite3_file(sqlite3_vfs* vfs, int fd, int dirfd, sqlite3_file* file, const char* fileName, int noLock);
> int chromium_sqlite3_get_reusable_file_handle(sqlite3_file* file, const char* fileName, int flags, int* fd);
> void chromium_sqlite3_update_reusable_file_handle(sqlite3_file* file, int fd, int flags);
> void chromium_sqlite3_destroy_reusable_file_handle(sqlite3_file* file);
> }

I just started to look at the issue, and haven't got much detail yet. Just think there may ght be demand for use_system_sqlite=1, with reasons just like use_system_skia=1 and use_system_libjpeg, etc.

Just read http://code.google.com/p/chromium/issues/detail?id=22208 and noticed that this is still a pending issue at chromium side. As the bug at chromium side is still open, I think we'd better also keep this one open if fixing at chromium side is not enough to fix the issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.