[Webkit-unassigned] [Bug 75602] [JSC] Short circuit for a 16 bit pattern character and an 8 bit string failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75602





--- Comment #15 from hojong.han at samsung.com  2012-02-23 17:45:09 PST ---
(In reply to comment #13)
> (From update of attachment 128449 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128449&action=review
> 
> r+
> 
> > Source/JavaScriptCore/yarr/YarrJIT.cpp:819
> > +        if (!((ch > 0xff) && (m_charSize == Char8))) {
> 
> Please add a comment similar to what was removed.
> 
> > Source/JavaScriptCore/yarr/YarrJIT.cpp:879
> > +            JumpList nonGreedyFailures;
> 
> Add a comment here as well.

Thank you for your review.
I added comments, and uploaded new patch that has more comments on what you reviewed.
Didn't I need to upload the patch again?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.