[Webkit-unassigned] [Bug 79387] Limit WebGL Errors in Console to 10 per context

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 17:37:14 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79387





--- Comment #2 from Kenneth Russell <kbr at google.com>  2012-02-23 17:37:14 PST ---
(From update of attachment 128529)
View in context: https://bugs.webkit.org/attachment.cgi?id=128529&action=review

Looks good but would you mind doing one small refactoring to make maintenance easier?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:429
> +    , m_numGLErrorsToConsoleAllowed(10)

Could you define a const int maxGLErrorsAllowedToConsole at the top of the file and initialize this to that?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:470
> +    m_numGLErrorsToConsoleAllowed = 10;

Same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list