[Webkit-unassigned] [Bug 79239] [Chromium] video-referer.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79239





--- Comment #19 from Dale Curtis <dalecurtis at chromium.org>  2012-02-23 17:18:11 PST ---
(From update of attachment 128545)
View in context: https://bugs.webkit.org/attachment.cgi?id=128545&action=review

>> LayoutTests/ChangeLog:6
>> +        Fix event setup race by moving setup into body onload() handler.
> 
> Please say something more specific.

Done.

>> LayoutTests/http/tests/media/video-referer.html:18
>>          frame.addEventListener('load', function () {
> 
> Shouldn't this listener be added before frame.src is set in the previous line?

Done.

>> LayoutTests/http/tests/media/video-referer.html:25
>> +        waitForEventAndEnd('error', function () {
> 
> Shouldn't the listeners be getting added right before the video.load() call above, if no errors are expected?

Done.

>> LayoutTests/http/tests/media/video-referer.html:26
>> +            consoleWrite('FAIL, got error when loading media.');
> 
> IWBN to use waitForEventAndFail() instead of wFEAEnd() for 'error'.
> (both this suggestion and the next will require you to edit the expected file).

Done.

>> LayoutTests/http/tests/media/video-referer.html:29
>> +        waitForEvent('canplay', function () {
> 
> This would benefit from using waitForEventAndEnd.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.