[Webkit-unassigned] [Bug 79333] REGRESSION: Assertion failure in Document::setCompatibilityMode() (!m_styleSheets->length()) in fast/dynamic/crash-paint-no-documentElement-renderer.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79333





--- Comment #6 from Julien Chaffraix <jchaffraix at webkit.org>  2012-02-23 10:52:55 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 128406 [details] [details])
> > I had disabled the test in debug or skipped it for all platforms to avoid hitting the ASSERT
> 
> Where and how did you do that?

By adding the test to the appropriate test_expectations.txt & Skipped files.

> 
> > I don't know what happened but you should add the test to your platform accordingly instead of losing coverage on all platforms.
> 
> Are there platforms that don’t fail the assertion when running this test? 

No, all platform should hit the assertion in debug and this is expected.

> Skipped lists are platform-specific and are meant to address platform-specific issues. As far as I can tell, this test would cause the assertion to fail on any platform, so it should be disabled.

I understand your point and agree that it is unfortunate to have this test hit the assertion on all platforms. If the test were providing no coverage and be a maintenance burden, then yes disabling would be the way to go. However here it checks against regressing the crash from bug 64284 in release so the situation is not clear cut to me and I would rather keep this coverage.

I don't have the context of your wanting to disable this test so maybe there is something I am missing here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.