[Webkit-unassigned] [Bug 75602] [JSC] Short circuit for a 16 bit pattern character and an 8 bit string failed

Thu Feb 23 09:58:09 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=75602

Michael Saboff <msaboff at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128449|review?                     |review+
               Flag|                            |

--- Comment #13 from Michael Saboff <msaboff at apple.com>  2012-02-23 09:58:08 PST ---
(From update of attachment 128449)
View in context: https://bugs.webkit.org/attachment.cgi?id=128449&action=review

r+

> Source/JavaScriptCore/yarr/YarrJIT.cpp:819
> +        if (!((ch > 0xff) && (m_charSize == Char8))) {

Please add a comment similar to what was removed.

> Source/JavaScriptCore/yarr/YarrJIT.cpp:879
> +            JumpList nonGreedyFailures;

Add a comment here as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.