[Webkit-unassigned] [Bug 79318] [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79318


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128397|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-23 04:36:07 PST ---
(From update of attachment 128397)
View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282
> +    BlackBerry::Platform::NetworkRequest platformRequest;

Can probably remove the BlackBerry prefix.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:285
> +        platformRequest, BlackBerry::Platform::NavigationType(action.type()))) {

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287
> +            || action.type() == NavigationTypeFormResubmitted)

Can be just one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.