[Webkit-unassigned] [Bug 17171] [Gtk] script-confirm and script-prompt signals are not binding-friendly

Wed Feb 22 23:50:30 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=17171

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-22 23:50:30 PST ---
(In reply to comment #10)
> Due to the issues revealed in bug #53600 I'd recommend to wait on the decision of providing the MODAL type in this API. As much as possible should be learned from that bug about how to create and handle modal dialogs and only then should the decision be made whether or not modal dialogs can even be handled in an approach as suggested by this API.

I still think they are different things and should be handled differently, alert, confirm and prompt are modal dialogs too, so having alert, confirm, prompt and modal is indeed confusing. Also, as I said, alert, confirm and prompt are dialogs to show a message, or get user inoput, they are not supposed to show a web view, while window.showModalDialog() is actually a shortcut for window.open with the dialog feature. 

> Keeping the MODAL type out, there's three types left. In WebKit1, this basically turns three signals into just one. Should the old signals ('script-alert', 'script-confirm' and 'script-alert') eventually become deprecated? Removing is probably not acceptable.

Yes.

> WebKit2 currently carries the same three signals but should probably make that step and remove them in favour of the new one.

Yes, in webkit2 we can just remove the 3 signals. Regarding the implementation, I still think we should use a simple opaque boxed type allocated in the stack before emitting the signal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.