[Webkit-unassigned] [Bug 79300] Add Chromium gpu_tests to the flakiness dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79300





--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2012-02-22 16:56:59 PST ---
(From update of attachment 128330)
View in context: https://bugs.webkit.org/attachment.cgi?id=128330&action=review

For future reference, you need to mark a patch as r? to mark it as ready for review. If you use "webkit-patch upload" it will automatically create the bug, generate the ChangeLog entry for you and upload it marked for review.

Also, if you mark it as cq? then that indicates to the reviewer that you'd like them to add it to the commit-queue once they approve the patch.

R- just for the sorting issue.

> ChangeLog:9
> +        * ../../builders.js:
> +        * ../../dashboard_base.js:

These paths aren't right. Did you create this ChangeLog entry using prepare-ChangeLog?

> Tools/TestResultServer/static-dashboards/builders.js:53
> +    'Chromium': '@DEPS - chromium.org',
> +    'ChromiumChromiumOS': '@DEPS CrOS - chromium.org',
> +    'ChromiumWebkit': '@ToT - chromium.org',
> +    'ChromiumGPU': '@DEPS - chromium.org',

Nit: can you sort these alphabetically?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.