[Webkit-unassigned] [Bug 78404] [chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78404


Shawn Singh <shawnsingh at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shawnsingh at chromium.org




--- Comment #13 from Shawn Singh <shawnsingh at chromium.org>  2012-02-22 10:14:51 PST ---
(In reply to comment #12)
> > 
> > > Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp:-327
> > > -    if (m_maskLayer == maskLayer)
> > > -        return;
> > > -
> > 
> > does this mean that we'll always call noteLayerPropertyChangedForSubtree() even if we're setting the mask layer to the same thing it used to be? that'll pretty much completely disable scissoring and any other damage tracking based optimizations for pages that have masks or replicas :/
> > 
> > is there any way to preserve this?  maybe use IDs instead of pointers if we need to?
> 
> By using PassOwnPtr/OwnPtr we automatically prevent this from happening. Comparing two own pointers should always return false because an object can't be owned by two at the same time. (wtf emits compile error if you try to compare)
> 


I was just "driving by", and this detail is still unclear to me.  Tien-Ren@ can you please clarify?  Do you mean that somehow we still retain the benefit of the early-exit?  If so, how does it work - am I missing something obvious?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.