[Webkit-unassigned] [Bug 17171] [Gtk] script-confirm and script-prompt signals are not binding-friendly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 10:08:54 PST 2012


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-22 10:08:54 PST ---
I like the the idea of using a single signal for the 3 dialogs, but showModalDialog has nothing to do with these dialogs imo. These are also indeed modal dialogs, and they have to run syncrhonously. With the current api that is pretty clear, because you have to return the result as an out parameter, but passing an object might give the idea that you can ref the object and handle the request later asynchronously, like policy client api. So, I would suggest rename the signal as run-modal-javascript-dialog, and the object passed be a simple boxed type (instead of a full gobject) that we can allocate on the stack so that its scope is the signal emission.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list