[Webkit-unassigned] [Bug 53600] [GTK] Add support for window.runModalDialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53600





--- Comment #27 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-22 10:04:11 PST ---
(In reply to comment #24)
> (From update of attachment 128211 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128211&action=review
> 
> One very important thing about this signal is that the client must be able to differentiate between modal dialogs and normal child WebViews. Imagine an application that makes a modal WebView an overlay over an existing one, instead of a new window. 
> 
> Is web-view-ready called for modal dialogs? If it is and especially if it's called before run-web-view-as-modal, it's going to be really tricky to pack the modal dialog WebView properly.  There is no create-modal-web-view, like in the Mac port, to know to pack the widget differentily.

Yes, as I said in comment #11. ShowModaldialog is:

1.- create-web-view
2.- web-view.-ready (on the newly created web view)
3.- run-modal (on the newly created web view)
4.- close

That's the only way to create a modal web view.

> r- for now, until these issues are worked out or the documentation explains it. Thank you for updating your patch. I think this can definitely go into stable with just a little polish.

I think this patch should include unit tests too before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.