[Webkit-unassigned] [Bug 78481] [GTK] DRT doesn't support scheduleAsynchronousKeyDown.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 08:30:17 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78481





--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-22 08:30:18 PST ---
(In reply to comment #4)
> >> Tools/DumpRenderTree/gtk/EventSender.cpp:761
> >> +        sendKeyDown(static_cast<gpointer>(pressEvent));
> > 
> > I think I would prefer to have a proper function with the appropriate type for the argument that is called from here and from the idle callback.
> 
> Do you mean it looks better to wrap sendKeyDown and g_idle_add(sendKeyDown... in a function with arguments?
> For example, bool sendKeyDown(bool asynchronous)?

No, I mean sendKeyDown should take GdkEvent* pressEvent as the only argument. You would call it directly here, and you would have a handler for the idle that would also call it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list