[Webkit-unassigned] [Bug 71266] CSS2:text-decoration: <rt> element should not inherit text-decoration property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 03:37:36 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=71266


Koji Ishii <kojiishi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127519|0                           |1
        is obsolete|                            |




--- Comment #7 from Koji Ishii <kojiishi at gmail.com>  2012-02-22 03:37:36 PST ---
Created an attachment (id=128170)
 --> (https://bugs.webkit.org/attachment.cgi?id=128170&action=review)
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Previous patch modified CSSStyleSelector::adjustRenderStyle, but I found a similar bug 18611, which fixes RenderObject::getTextDecorationColors instead, so this patch follows that.

Two things are different from the previous patch:
* The check is slightly faster than the previous patch (one virtual call on paint(), while the previous patch checks two fields on attach().)
* The -webkit-text-decoration-in-effect was not set in the previous patch, but is set in this patch.

reftest is included. This is slightly improved from the previous patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list