[Webkit-unassigned] [Bug 79211] New: The error domain string "WebKitErrorDomain" should be used all-over

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79211

           Summary: The error domain string "WebKitErrorDomain" should be
                    used all-over
           Product: WebKit
           Version: 312.x
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: parmarpritish at gmail.com


Recently, the error domain string "WebKit" was replaced by "WebKitErrorDomain" in some places. This created problems in string matching at some places where it is still matching with old string "WebKit". And Qt is not able to call the error page extension though it is supported.

For eg:
The WebCore::ResourceError is initialized with error domain as "WebKitErrorDomain" in following functions -
FrameLoaderClientQt::blockedError(),
FrameLoaderClientQt::cannotShowURLError(),
FrameLoaderClientQt::interruptForPolicyChangeError(),
FrameLoaderClientQt::cannotShowMIMETypeError(),

And it is initialized with error domain as "WebKit" in following functions -
FrameLoaderClientQt::pluginWillHandleLoadError()

These error domains are compared with the string "WebKit" in -
FrameLoaderClientQt::callErrorPageExtension()

The best suggestion is to convert the strings into enum values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.