[Webkit-unassigned] [Bug 53600] [GTK] Add DRT support for modal dialogs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53600





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-22 01:25:35 PST ---
(From update of attachment 126324)
View in context: https://bugs.webkit.org/attachment.cgi?id=126324&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2748
> +     * @webView: the object which received the signal

This should be @web_view

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2751
> +     * avoided if FALSE is returned in the signal handler. Otherwise, the

%FALSE

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2752
> +     * @webView (or its toplevel window) should be made transient for its parent,

@web_view

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2753
> +     * set as a modal window, and TRUE should be returned in the signal handler.

%TRUE

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2754
> +     * After that, a loop will be created and run until the @webView is closed

@web_view

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2756
> +     * (i.e. its chrome is destroyed).
> +     *

Signal is true_handled, it should include information about the Return value:

* Return value: %TRUE to stop handlers from being invoked for the event or                                                                                                              
     * %FALSE to propagate the event furter

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.