[Webkit-unassigned] [Bug 53600] [GTK] Add DRT support for modal dialogs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53600





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-22 00:03:41 PST ---
(From update of attachment 126324)
View in context: https://bugs.webkit.org/attachment.cgi?id=126324&action=review

I know I'm late, but I've found several issues in this patch.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2746
>      /*

Double * missing here

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2747
> +     * WebKitWebView::run-modal-dialog

Trailing : missing here. also the name is a bit confusing, it seems this signal is to run a modal dialog, while it actually runs the toplevel window of the web view in modal mode.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2757
> +     * Since: 1.7.6

This version doesn't exist, it's 1.7.90

> Source/WebKit/gtk/webkit/webkitwebview.cpp:2759
> +    webkit_web_view_signals[RESOURCE_LOAD_FAILED] = g_signal_new("run-modal-dialog",

RESOURCE_LOAD_FAILED -> that should be RUN_MODAL_DIALOG

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:962
> +    GtkWindow* viewTopLevel = GTK_WINDOW(gtk_widget_get_toplevel(GTK_WIDGET(view)));

You should check that returned widget is actually a toplevel and a GdkWindow. We have a method in GtkUtilities to check this properly.

> Tools/GtkLauncher/main.c:134
> +    GtkWidget *window = gtk_widget_get_toplevel(GTK_WIDGET(webView));
> +    gtk_window_set_transient_for(GTK_WINDOW(window), GTK_WINDOW(openerWindow));
> +    gtk_window_set_modal(GTK_WINDOW(window), TRUE);
> +    return TRUE;

Instead of duplicating this in GtkLauncher and DRT, this should be default implementation when the signal is not handled in WebView

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.