[Webkit-unassigned] [Bug 76816] Implement the URL decomposition IDL attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76816


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127144|review?                     |review-
               Flag|                            |




--- Comment #13 from Kentaro Hara <haraken at chromium.org>  2012-02-21 23:14:33 PST ---
(From update of attachment 127144)
View in context: https://bugs.webkit.org/attachment.cgi?id=127144&action=review

> Source/WebCore/ChangeLog:7
> +

Please describe what your patch is doing.
Isn't there any spec to support this change?

> Source/WebCore/html/DOMURL.idl:33
> +        Replaceable

[Replaceable] cannot be specified on an interface. What did you intend by [Replaceable]? Please see the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL).

> Source/WebCore/html/DOMURL.idl:45
> +        readonly attribute DOMString origin;

Maybe "readonly attribute [Reflect, URL] DOMString origin"? Please confirm the spec and the WebKit IDL document.

> Source/WebCore/html/DOMURL.idl:46
> +        stringifier attribute DOMString href;

stringifier is not implemented by any code generators. Maybe "attribute [Reflect, URL] DOMString href"?

> Source/WebCore/html/DOMURL.idl:47
> +        [DontEnum] DOMString toString();

[DontEnum] is renamed to [NotEnumerable]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.