[Webkit-unassigned] [Bug 77068] [chromium] Add WebCore::FlingAnimator class for Android native-feel scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77068


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124057|review?                     |review-
               Flag|                            |




--- Comment #2 from James Robinson <jamesr at chromium.org>  2012-02-21 20:55:24 PST ---
(From update of attachment 124057)
View in context: https://bugs.webkit.org/attachment.cgi?id=124057&action=review

I think that attempting to call straight into Java from WebKit is a bad approach (not to mention it won't compile on all of our configs).  Better would be to provide WebKit API for the embedder to control the fling animation curves and then call into that.

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:29
> +#include "base/android/jni_android.h"

you can't #include files from base/ inside WebKit.  This won't even compile

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:56
> +    JNIEnv* env = AttachCurrentThread();

calling into Java straight from WebKit?  Ick.  How do you plan to test this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.