[Webkit-unassigned] [Bug 78028] Decouple scrollbar painting from Scrollbar object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78028





--- Comment #27 from James Robinson <jamesr at chromium.org>  2012-02-21 16:09:16 PST ---
(From update of attachment 128027)
View in context: https://bugs.webkit.org/attachment.cgi?id=128027&action=review

> Source/WebCore/platform/Scrollbar.h:64
> +    virtual ScrollbarOrientation orientation() const { return m_orientation; }

please group the virtual overrides for ScrollbarThemeClient together and document what interface they are implementing (this file is not a great example of this pattern, but other files have a comment saying something like "// ScrollbarThemeClient implementation." at the top of a block of virtuals).

> Source/WebCore/platform/ScrollbarThemeClient.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

it's 2012 now

> Source/WebCore/platform/mac/ScrollbarThemeMac.h:29
> +#include "Scrollbar.h"

is this #include needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.