[Webkit-unassigned] [Bug 78840] Abstract ImageEventSender into a general purpose EventSender

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78840


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127464|review?                     |review+
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-02-21 12:35:54 PST ---
(From update of attachment 127464)
View in context: https://bugs.webkit.org/attachment.cgi?id=127464&action=review

> Source/WebCore/dom/EventSender.h:88
> +    if (m_dispatchSoonList.isEmpty())
> +        m_timer.stop();

Do you mean to check whether the list is empty or whether it contains all zeros?  I'm not sure how this function could result in m_dispatchSoonList being empty if it wasn't already empty.

> Source/WebCore/loader/ImageLoader.cpp:-385
> -    if (m_dispatchSoonList.isEmpty())
> -        m_timer.stop();

I see this was here already.  We might want to ask the original author why they intended here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.