[Webkit-unassigned] [Bug 78481] [GTK] DRT doesn't support scheduleAsynchronousKeyDown.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78481





--- Comment #4 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-02-21 10:41:36 PST ---
(From update of attachment 127978)
View in context: https://bugs.webkit.org/attachment.cgi?id=127978&action=review

Thanks for the review :)

>> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:53
>> +#include "PlatformKeyboardEvent.h"
> 
> Why do we need this extra include?

Oops. Sorry :p

>> Tools/DumpRenderTree/gtk/EventSender.cpp:761
>> +        sendKeyDown(static_cast<gpointer>(pressEvent));
> 
> I think I would prefer to have a proper function with the appropriate type for the argument that is called from here and from the idle callback.

Do you mean it looks better to wrap sendKeyDown and g_idle_add(sendKeyDown... in a function with arguments?
For example, bool sendKeyDown(bool asynchronous)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.