[Webkit-unassigned] [Bug 78481] [GTK] DRT doesn't support scheduleAsynchronousKeyDown.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78481


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127978|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-21 09:57:52 PST ---
(From update of attachment 127978)
View in context: https://bugs.webkit.org/attachment.cgi?id=127978&action=review

r-, although it's just for a few nitpicks and a possible useless include, I think you'll prefer to upload a new patch anyway? =)

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:53
> +#include "PlatformKeyboardEvent.h"

Why do we need this extra include?

> Tools/DumpRenderTree/gtk/EventSender.cpp:761
> +        sendKeyDown(static_cast<gpointer>(pressEvent));

I think I would prefer to have a proper function with the appropriate type for the argument that is called from here and from the idle callback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.