[Webkit-unassigned] [Bug 78559] [EFL][DRT] Add initial implementation for TextInputController.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78559





--- Comment #4 from Kangil Han <kangil.han at samsung.com>  2012-02-21 00:48:09 PST ---
Done and thank you for reviewing my patch! :)

(In reply to comment #2)
> (From update of attachment 126877 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126877&action=review
> 
> > Tools/DumpRenderTree/efl/TextInputController.cpp:14
> > + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> 
> I guess you don't need to claim anything about Apple ;-)
> 
> > Tools/DumpRenderTree/efl/TextInputController.cpp:40
> > +static JSValueRef setMarkedTextCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
> 
> Typically we don't give argument names which are not used in the function.
> Some compiler actually complain about that.
> 
> > Tools/DumpRenderTree/efl/TextInputController.h:14
> > + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> 
> Ditto for license.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.