[Webkit-unassigned] [Bug 78473] ShadowRoot needs innerHTML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78473


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127573|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from MORITA Hajime <morrita at google.com>  2012-02-20 22:18:35 PST ---
(From update of attachment 127573)
View in context: https://bugs.webkit.org/attachment.cgi?id=127573&action=review

> Source/WebCore/dom/ShadowRoot.cpp:156
> +        replaceChildrenWithFragment(host(), fragment.release(), ec);

No, this is not what we need. we need to inject fragment to this ShadowRoot, not the host.

> LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html:24
> +shouldBeDefined("root.innerHTML");

This is not enough. We need to test
- the resulted string of innerHTML after setting innerHTML.
- the resulted DOM tree after setting innerHTML
- the innerHTML value for existing shadow DOM tree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.