[Webkit-unassigned] [Bug 78684] Layout issue with fieldset legend element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78684


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127791|review?                     |review-
               Flag|                            |




--- Comment #10 from MORITA Hajime <morrita at google.com>  2012-02-20 21:52:43 PST ---
(From update of attachment 127791)
View in context: https://bugs.webkit.org/attachment.cgi?id=127791&action=review

Thanks for taking this! 
The code basically looks OK. What's left is bureaucratic part...

1. It looks you don't set the mime type of the png files correctly. 
    Please check your svn configuration.
    http://trac.webkit.org/wiki/UsingGitWithWebKit

2. On chromium bot (cr-linux) redness, you can mark "fail" to these failing test to make the bot OK.
    Someone from Chromium land will care about that then.
    http://trac.webkit.org/wiki/TestExpectations

> Source/WebCore/rendering/RenderFieldset.cpp:165
> +        LayoutUnit clipWidth = (max(static_cast<LayoutUnit>(style()->borderLeftWidth()), legend->width()));

Apparently this change isn't required.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.