[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #43 from Jongseok Yang <js45.yang at samsung.com>  2012-02-20 21:42:17 PST ---
(In reply to comment #38)
> (In reply to comment #37)
> 
> Thank you for your review. Could you please check my comment?
> 
> > (In reply to comment #36)
> > 
> > I took a look at the draft.
> >  - The draft is old.  Is the WG working on it actively?
> 
>  I'll check it.
> 
> >  - We should support media capture regardless of existence of 'capture' attribute.
> >   http://www.w3.org/TR/2011/WD-html-media-capture-20110414/#formaccess
> 
>  I agree with you.
> 
> >  - I don't think we need to use both of Chrome::runOpenPanel and Chrome::runCapturePanel. runCapturePanel should support file choosing, and we should always use Chrome::runCapturePanel if ENABLE_HTML_MEDIA_CAPTURE.
> 
>  I agree with you. I'll fix that

http://www.w3.org/TR/html-media-capture/#formaccess
I re-checked the spec. The panel for HTML Media Capture should be enabled only if the accept accept attribute with values image/*, audio/*, or video/*.

> 
> >  - I don't think showing a captured file name makes sense. We had better show a captured media information such as:
> >    "1280x768 still image (123KB)" (with a thumbnail?)
> >    "35 second audio (63KB)"
> 
>  I think that WebIDL interface in the spec is for the media information you mentioned. 
>  Please check the example : http://www.w3.org/TR/2011/WD-html-media-capture-20110414/#jsexample
>  So, I think we need not show the media information.
> 
> > 
> > > > > Source/WebCore/platform/FileChooser.cpp:72
> > > > > +    if (equalIgnoringCase(input->capture(), MediaCaptureNames::camera())) {
> > > > 
> > > > input->capture() should be input->fastGetAttribute(captureAttr), and should remove HTMLInputElement::capture().
> > > > Anyway, this is a layering violation.
> > > 
> > > capture() is the wrapper function for fastGetAttribute(captureAttr). I observed the same logic from HTMLInputElement::accept(), HTMLInputElement::alt() and HTMLInputElement::multiple(). Do you mean that these functions are also layering violation?
> > 
> > I meant using HTMLInputElement in platform/FileChooser.cpp was a layering violation.
> 
> OK, I will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.