[Webkit-unassigned] [Bug 75078] [GStreamer] media/W3C failures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75078


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127597|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-02-20 11:24:54 PST ---
(From update of attachment 127597)
View in context: https://bugs.webkit.org/attachment.cgi?id=127597&action=review

What is the meaning of PASS "maybe" is "maybe" in the new baselines?

Please take a look at the suggestion below before landing.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:288
> +    KURL kurl(KURL(), url);
> +    String cleanUrl(url);

I think it would be better here to do:

if (kurl.isLocalFile()) {
    kurl.setQuery("");
    kurl.removeFragmentIdentifier();
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.