[Webkit-unassigned] [Bug 78953] New: Discrepancies between source nightly-build and respective SVN revisions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78953

           Summary: Discrepancies between source nightly-build and
                    respective SVN revisions
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ashodnakashian at yahoo.com


The source nightly-builds found at http://nightly.webkit.org/builds/trunk/src/1 have important discrepancies from their respective SVN revisions. Some of these are intentional, such as the exclusion of the tests folders, and are not the subject of this bug.

The source nightly-build should maximally reproduce the respective SVN revision and should never alter the exported files, especially in ways that may break the build.

Concretely, here are three types of discrepancies that may have serious consequences:

1) Missing folders with all their contents.
   This includes many android folders as well as gyp, qt and related folders and files. This may be intentional and, unless building affected ports should be supported from source nightly-builds, they may remained excluded from these dumps.

2) Differences in contents.
   Some files contain vastly different code in them. This either suggests intentionally placing different versions of these files in the source nightly-builds as opposed to the SVN or they come from a different origin or revision than the one advertised by the nightly-build. Files of note in this category are Tools\BuildSlaveSupport\build-launcher-app, Tools\BuildSlaveSupport\build-launcher-dmg, Tools\WebKitLauncher\Configurations\Base.xcconfig and Tools\WebKitLauncher\WebKitLauncherURLProtocol.m to name but a few.

3) Differences in formatting.
   Some files that otherwise don't differ in content differ in formatting or line-ending. Of these files WebKitLibraries\win\tools\scripts\feature-defines.sh is the most notable, which has CRLF ending in SVN while in the source nightly-builds its line-endings are LF only. Unfortunately, this small difference is breaking the build on some Cygwin systems. For completeness, here is a partial output from a failed build:

4>------ Build started: Project: WebCoreGenerated, Configuration: Release_Cairo_CFLite Win32 ------
4>        0 [main] which 22080 tty_list::allocate: No tty allocated
4>  /usr/bin/bash
4>        0 [main] bash 5760 tty_list::allocate: No tty allocated
4>  /cygdrive/c/Cygwin/home/Ash/r107399/WEBKIT~1/win/tools/scripts/feature-defines.sh: line 2: $'\r': command not found
4>  /cygdrive/c/Cygwin/home/Ash/r107399/WEBKIT~1/win/tools/scripts/feature-defines.sh: line 24: $'\r': command not found
4>  /cygdrive/c/Cygwin/home/Ash/r107399/WEBKIT~1/win/tools/scripts/feature-defines.sh: line 32: syntax error: unexpected end of file

Fortunately, the SVN version causes no issues and, it's reasonable to assume, it also works on other platforms/systems. Therefore the remedy is to simply avoid any line-ending conversions while exporting the nightly-builds.

The revision used to generate this report was r107399. The source nightly-build can be found at http://builds.nightly.webkit.org/files/trunk/src/WebKit-r107399.tar.bz2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.